Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add turnkey signer to aa-signers #307

Merged
merged 11 commits into from
Dec 5, 2023
Merged

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Dec 5, 2023

  • feat: add turnkey signer to aa-signers
  • test: add tests for turnkey signer
  • refactor: use turnkey stamper interface
  • refactor: rename TurnkeyAuthMetadata
  • docs: add turnkey aa-sign docs and update turnkey snippet
  • refactor: use webauthn stamper in turnkey test and examples
  • docs: add turnkey section in aa-signers. update turnkey smart account doc
  • chore: accidentally deleted yarn.lock in 8fb9b74. run linter
  • docs: turnkey smart account doc
  • docs: include new turnkey/iframe-stamper as auth option
  • refactor: use resolveSubOrganization for turnkey auth params

Pull Request Checklist


PR-Codex overview

This PR adds support for the TurnkeySigner in the signers package. The notable changes include:

  • Exporting the TurnkeySigner and TurnkeyAuthParams from the turnkey/index.ts file.
  • Adding the TurnkeySigner and TurnkeySubOrganization classes to the turnkey/signer.ts file.
  • Adding the TurnkeyAuthParams, TurnkeySubOrganization, and TurnkeyUserMetadata interfaces to the turnkey/types.ts file.
  • Adding the getAddress, signMessage, getAuthDetails, and signTypedData methods to the site/packages/aa-signers/turnkey/ directory.
  • Adding the constructor method to the site/packages/aa-signers/turnkey/constructor.md file.
  • Adding the getAddress, signMessage, getAuthDetails, and signTypedData methods to the site/packages/aa-signers/turnkey/ directory.

The following files were skipped due to too many changes: packages/signers/src/turnkey/signer.ts, site/packages/aa-signers/turnkey/introduction.md, packages/signers/src/turnkey/__tests__/signer.test.ts, site/smart-accounts/signers/guides/turnkey.md, site/packages/aa-signers/turnkey/authenticate.md, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@moldy530 moldy530 merged commit 4fa05e4 into main Dec 5, 2023
2 checks passed
@moldy530 moldy530 deleted the olivia/add-turnkey-signer branch December 5, 2023 20:49
avasisht23 pushed a commit that referenced this pull request Jan 9, 2024
* feat: add turnkey signer to aa-signers

* test: add tests for turnkey signer

* refactor: use turnkey stamper interface

* refactor: rename TurnkeyAuthMetadata

* docs: add turnkey aa-sign docs and update turnkey snippet

* refactor: use webauthn stamper in turnkey test and examples

* docs: add turnkey section in aa-signers. update turnkey smart account doc

* chore: accidentally deleted yarn.lock in 8fb9b74. run linter

* docs: turnkey smart account doc

* docs: include new turnkey/iframe-stamper as auth option

* refactor: use resolveSubOrganization for turnkey auth params

---------

Co-authored-by: Olivia Thet <olivia@turnkey.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants