-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add turnkey signer to aa-signers #307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
December 5, 2023 20:01
8 tasks
avasisht23
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
avasisht23
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat: add turnkey signer to aa-signers * test: add tests for turnkey signer * refactor: use turnkey stamper interface * refactor: rename TurnkeyAuthMetadata * docs: add turnkey aa-sign docs and update turnkey snippet * refactor: use webauthn stamper in turnkey test and examples * docs: add turnkey section in aa-signers. update turnkey smart account doc * chore: accidentally deleted yarn.lock in 8fb9b74. run linter * docs: turnkey smart account doc * docs: include new turnkey/iframe-stamper as auth option * refactor: use resolveSubOrganization for turnkey auth params --------- Co-authored-by: Olivia Thet <olivia@turnkey.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR adds support for the TurnkeySigner in the signers package. The notable changes include: