Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment spacing #284

Closed
elydpg opened this issue Nov 9, 2016 · 2 comments
Closed

Comment spacing #284

elydpg opened this issue Nov 9, 2016 · 2 comments
Assignees
@daveyarwood
Labels
bug

Comments

@elydpg
Copy link
Contributor

elydpg commented Nov 9, 2016

There seems to be spacing issues when a comment marks the end of a newline

piano "pi": c d e f g#hi
piano "pa": c d e f g

Throws syntax error

piano "pi": c d e f g
piano "pa": c d e f g

Plays normally
@daveyarwood
Copy link
Member

Nice find!

ERROR Stock instrument "gpiano" not defined.

is the error that gets thrown. It looks like the parser is including newlines in what it strips out of the score for each line comment, whereas we should be leaving in that final newline, so that the first score you posted should effectively be equivalent to the second score.

Should be relatively easy to fix -- I'll take a look when I have some time.

@daveyarwood daveyarwood self-assigned this Nov 9, 2016
@daveyarwood
Copy link
Member

daveyarwood commented Nov 9, 2016 •
edited

Fixed in 1.0.0-rc47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daveyarwood daveyarwood

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveyarwood @elydpg