Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"get_tables" and "get_meta" functions removed #70

Closed
holtgrewe opened this issue Mar 19, 2019 · 2 comments · Fixed by #72
Closed

"get_tables" and "get_meta" functions removed #70

holtgrewe opened this issue Mar 19, 2019 · 2 comments · Fixed by #72

Comments

@holtgrewe
Copy link

But they are still imported in the top level module and at least get_tables() is referred to in the README.

@ryanhiebert
Copy link
Member

ryanhiebert commented Mar 20, 2019

What do you mean the "top level module"? The __init__.py doesn't import them, AFAICT. https://github.com/Deepwalker/aldjemy/blob/master/aldjemy/__init__.py

That said, you're right that get_tables still documented in the README. I did mention about that change when my PR removing it was removed, but I didn't catch that it was documented in the README at the time. I'm not sure what he would prefer as a direction. Do you have a preference? I think I'd be inclined toward removing them from the docs, I'm not sure they make a ton of sense to be part of the public API.

@holtgrewe
Copy link
Author

@ryanhiebert Yes, you were right. It is still here but could just be removed https://github.com/Deepwalker/aldjemy/blob/4c2338b32c69e9aeec8af5b4496d3f325ce02a76/aldjemy/core.py#L15

It would be nice if the documentation had an example of how to get to this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants