Merge pull request #268 from aldryn/feature/unit-tests-update

Added more unit tests

aldryn_newsblog/boilerplates/bootstrap3/static/js/addons/cl.newsblog.js

@@ -23,22 +23,27 @@ var Cl = window.Cl || {};
             });
         },
 
+        _handler: function (e) {
+            e.preventDefault();
+
+            var form = $(this);
+
+            $.ajax({
+                type: 'GET',
+                url: form.attr('action'),
+                data: form.serialize()
+            }).always(function (data) {
+                form.siblings('.js-search-results').html(data);
+            }).fail(function () {
+                alert('REQUEST TIMEOUT');
+            });
+        },
+
+        // container should be a jQuery object
         _search: function (container) {
             var form = container.find('form');
 
-            form.on('submit', function (e) {
-                e.preventDefault();
-
-                $.ajax({
-                    type: 'GET',
-                    url: form.prop('action'),
-                    data: form.serialize()
-                }).always(function (data) {
-                    form.siblings('.js-search-results').html(data);
-                }).fail(function () {
-                    alert('REQUEST TIMEOUT');
-                });
-            });
+            form.on('submit', this._handler);
         }
 
     };

aldryn_newsblog/tests/frontend/fixtures/search.html

@@ -1,2 +1,24 @@
 <div class="js-aldryn-newsblog-article-search">
 </div>
+
+<div class="js-aldryn-newsblog-article-search">
+    <form action="/en/blog/search/" class="form-inline" method="get">
+        <input type="hidden" name="csrfmiddlewaretoken"
+            value="Ui0tGBmn0Thq5LUeUS2m4zAF20H0M8up">
+        <input type="hidden" name="max_articles" value="10">
+        <div class="input-group">
+            <label for="field-17989-keyword" class="sr-only">Keyword search
+                </label>
+            <input type="text" name="q" class="form-control"
+                id="field-17989-keyword" placeholder="Keyword">
+            <span class="input-group-btn">
+                <button type="submit" class="btn btn-primary">Go</button>
+            </span>
+        </div>
+    </form>
+    <div class="search-results js-search-results">
+        <ul class="results-list list-unstyled">
+            <h3>Most recent articles containing "<strong>test</strong>"</h3>
+        </ul>
+    </div>
+</div>

aldryn_newsblog/tests/frontend/unit/test.cl.newsblog.js

@@ -32,6 +32,39 @@ describe('cl.newsblog.js:', function () {
             expect(Cl.newsBlog.init()).toEqual(undefined);
         });
 
+        it('runs _search()', function () {
+            spyOn(Cl.newsBlog, '_search');
+            Cl.newsBlog.init();
+
+            // validate that _search was called inside Cl.newsBlog.init()
+            expect(Cl.newsBlog._search).toHaveBeenCalled();
+            // validate 2 call as 2 js-aldryn-newsblog-article-search is
+            // specified in search.html
+            expect(Cl.newsBlog._search.calls.count()).toEqual(2);
+        });
+    });
+
+    describe('Cl.newsBlog._search: ', function () {
+        it('returns undefined', function () {
+            // validate the return of undefined
+            expect(Cl.newsBlog._search(
+                $('.js-aldryn-newsblog-article-search').eq(1)))
+                    .toEqual(undefined);
+        });
+
+        it('has correct url in ajax request', function () {
+            spyOn($, 'ajax').and.callThrough();
+            Cl.newsBlog._handler.call(
+                $('.js-aldryn-newsblog-article-search .form-inline')[0],
+                    this.preventEvent);
+
+            var callArgs = $.ajax.calls.allArgs()[0][0];
+
+            // validate ajax request url
+            expect(callArgs.url).toEqual(
+                '/en/blog/search/'
+            );
+        });
     });
 
 });