Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Use default manager for all objects, separate manager - for published #86

Merged
merged 5 commits into from Mar 3, 2015

Conversation

mikek
Copy link
Contributor

@mikek mikek commented Mar 3, 2015

Solves this issue: #74

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 97.68% when pulling 752d3a0 on issue/default-manager into abfa71b on master.

@intellectronica
Copy link
Contributor

👍

def get_query_set(self):
qs = super(PublishedRelatedManager, self).get_query_set().filter(
is_published=True)
return qs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't agree with add one more manager to Article model just to filter published items. We must have a published method in manager and queryset, something like that:

from parler.managers import TranslatableManager, TranslatableQuerySet


class ArticleQuerySet(TranslatableQuerySet):

    def published(self):
        return self.filter(is_published=True)


class ArticleManager(TranslatableManager):

    def get_queryset(self):
        return ArticleQuerySet(self.model, using=self.db)

    def published(self):
        return self.get_query_set().published()

This way you can use published anytime in a query, for example:

language = get_language_from_request(request, check_path=True)
events = Event.objects.language(language).translated(language)

if only_published:
    events = events.published()

@chronossc
Copy link
Contributor

👍 , merge if travis say that is ok :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 97.68% when pulling e8eaa80 on issue/default-manager into abfa71b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 97.68% when pulling e8eaa80 on issue/default-manager into abfa71b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) to 97.71% when pulling 2a0c428 on issue/default-manager into abfa71b on master.

@mikek mikek merged commit 2a0c428 into master Mar 3, 2015
@mikek mikek deleted the issue/default-manager branch March 3, 2015 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants