Adds tests for get_object_from_request #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoistinen
force-pushed
the
mkoistinen/test_get_object_from_request
branch
from
cd9f4c4
to
a41a36f
Compare
| try: | ||
| translated_fields = model._parler_meta.get_translated_fields() | ||
| except AttributeError: | ||
| translated_fields = None |
There was a problem hiding this comment.
you could save a condition by making this an empty list and simply checking if slug_url_kwarg in translated_fields
|
LGTM. Ok to merge once tests pass. |
mkoistinen
added a commit
that referenced
this pull request
Aug 19, 2015
…uest Adds tests for get_object_from_request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.