Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intentional fallthroughs? #501

Closed
r-barnes opened this issue Jul 22, 2024 · 1 comment · Fixed by #499
Closed

Intentional fallthroughs? #501

r-barnes opened this issue Jul 22, 2024 · 1 comment · Fixed by #499

Comments

@r-barnes
Copy link

Are these fallthroughs intentional? If so, can we mark them with __attribute__((fallthrough)) so that -Wimplicit-fallthrough will pass with them. If not, can we add break to fix the bug(s)?

gmpy/src/gmpy2_mpmath.c

Line 290 in 30f6ef6

case 3:

gmpy/src/gmpy2_mpmath.c

Line 296 in 30f6ef6

case 2:

gmpy/src/gmpy2_mpmath.c

Line 298 in 30f6ef6

case 1:

@skirpichev
Copy link
Contributor

Are these fallthroughs intentional?

Absolutely.

@skirpichev skirpichev mentioned this issue Jul 23, 2024
Merged
@casevh casevh closed this as completed in 44e879d Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc fixes skirpichev/gmpy
2 participants
@skirpichev @r-barnes