Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Swift 1.2 #5

Merged
merged 1 commit into from
Apr 18, 2015
Merged

Updates for Swift 1.2 #5

merged 1 commit into from
Apr 18, 2015

Conversation

vittoriom
Copy link
Contributor

I ran Xcode migration tool. After that, I had to apply some manual changes:

  • I removed the assigned value to the isConcurrent DispatchQueue constant. It was confusing for me to see it re-assigned in the initializers
  • I also assigned the gcd.serial() value to the queue constant inline with its declaration in DispatchTimer
  • I had to remove the sync and async implementations that accept an @autoclosure callback in the DispatchQueue class because of how autoclosure works now in Swift 1.2 (in particular, @autoclosure implies @noescape, that certainly doesn't work for the async method, but seems to not work for the sync either, due to some issues with the dispatch_sync (that obviously doesn't mark its parameter with @noescape or @autoclosure).
  • Of course I had to update the tests code to explicitly use a closure where @autoclosure was used before.

Let me know if you need something else

16 tests are passing.

16 tests passing
@aleclarson
Copy link
Owner

Wow, thanks for your great work! 😄

I'm just going to auto-merge this and hope it all works right. Don't have any time to spend on this.

Thanks again!

@aleclarson aleclarson closed this Apr 18, 2015
@aleclarson aleclarson reopened this Apr 18, 2015
aleclarson added a commit that referenced this pull request Apr 18, 2015
@aleclarson aleclarson merged commit b5b2682 into aleclarson:master Apr 18, 2015
@vittoriom
Copy link
Contributor Author

No problem! We are using your library and I thought it would have been nice to give something back :) Everything should work, assuming the tests are correctly testing :)
Worst case, next week we'll try the 1.2 version out and submit some other PR if something is not working :P

@aleclarson
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants