Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery page is missing the catpuccin styles #719

Closed
walles opened this issue Dec 29, 2022 · 6 comments
Closed

Gallery page is missing the catpuccin styles #719

walles opened this issue Dec 29, 2022 · 6 comments

Comments

@walles
Copy link
Contributor

walles commented Dec 29, 2022

Describe the bug

The Gallery page linked to from your README.md is missing the catpuccin styles:

For a quick overview of the available styles and how they look, check out the [Chroma Style Gallery](https://xyproto.github.io/splash/docs/).

I would like this page specifically to be up to date:
https://xyproto.github.io/splash/docs/longer/all.html

To Reproduce

  1. Go to your README.md: https://github.com/alecthomas/chroma/blob/master/README.md
  2. Click the Chroma Style Gallery link
  3. Scroll to the bottom
  4. Click the All styles on one page link
  5. Search for catpuccin

Current result

Not found

Expected result

Catpuccin should be on that page since it's in the source code:
https://github.com/alecthomas/chroma/tree/master/styles

@alecthomas
Copy link
Owner

@xyproto maintains that page

@xyproto
Copy link
Contributor

xyproto commented Dec 29, 2022

Thanks for reporting! I updated the style gallery to include catpuccin. ✔️

@xyproto
Copy link
Contributor

xyproto commented Dec 30, 2022

However, it's not quite right yet, because the style gallery is unable to use the latest commit from master, or the latest tag. The go module system wants a "v2" directory to exist for version tags with a major number 2.

In the CI system that updates the gallery web page, I get:

go get github.com/alecthomas/chroma@$(git ls-remote --refs --heads https://github.com/alecthomas/chroma master | cut -f1)
go: github.com/alecthomas/chroma@45e3bfb671684372414f2ba3ed45439cc0193664: github.com/alecthomas/chroma@v0.10.1-0.20221211204142-45e3bfb67168: invalid version: go.mod has post-v0 module path "github.com/alecthomas/chroma/v2" at revision 45e3bfb67168
Error: Process completed with exit code 1.

https://github.com/xyproto/splash/actions/runs/3808417114/jobs/6478977475

@alecthomas
Copy link
Owner

You need to change go get github.com/alecthomas/chroma@$... to go get github.com/alecthomas/chroma/v2@$...

@xyproto
Copy link
Contributor

xyproto commented Dec 31, 2022

https://xyproto.github.io/splash/docs/ has been updated.

I also setup a GH action so that it should be updated every 24 hours, if there are changes to the Chroma master branch.

@alecthomas
Copy link
Owner

Great idea, thanks @xyproto !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants