Fix a false positive issue with dependency cycle detection

See the test code for details.

CHANGES

@@ -1,6 +1,12 @@
 Injector Change Log
 ===================
 
+0.10.1
+------
+
+- Fixed a false positive bug in dependency cycle detection (AssistedBuilder can be
+  used to break dependency cycles now)
+
 0.10.0
 ------
 

injector.py

@@ -34,7 +34,7 @@ def emit(self, record):
             pass
 
 __author__ = 'Alec Thomas <alec@swapoff.org>'
-__version__ = '0.10.0'
+__version__ = '0.10.1'
 __version_tag__ = ''
 
 log = logging.getLogger('injector')
@@ -862,10 +862,12 @@ def args_to_inject(self, function, bindings, owner_key):
         :returns: Dictionary of resolved arguments.
         """
         dependencies = {}
-        key = (owner_key, function)
+
+        key = (owner_key, function, tuple(sorted(bindings.items())))
 
         def repr_key(k):
-            return '%s.%s()' % tuple(map(_describe, k))
+            owner_key, function, bindings = k
+            return '%s.%s(injecting %s)' % (tuple(map(_describe, k[:2])) + (dict(k[2]),))
 
         log.debug('%sProviding %r for %r', self._log_prefix, bindings, function)
 

injector_test.py

@@ -373,6 +373,33 @@ def configure(binder):
         injector.get(A)
 
 
+def test_dependency_cycle_can_be_worked_broken_by_assisted_building():
+    class Interface(object):
+        pass
+
+    class A(object):
+        @inject(i=Interface)
+        def __init__(self, i):
+            self.i = i
+
+    class B(object):
+        @inject(a_builder=AssistedBuilder(A))
+        def __init__(self, a_builder):
+            self.a = a_builder.build(i=self)
+
+    def configure(binder):
+        binder.bind(Interface, to=B)
+        binder.bind(A)
+
+    injector = Injector(configure)
+
+    # Previously it'd detect a circular dependency here:
+    # 1. Constructing A requires Interface (bound to B)
+    # 2. Constructing B requires assisted build of A
+    # 3. Constructing A triggers circular dependency check
+    assert isinstance(injector.get(A), A)
+
+
 def test_avoid_circular_dependency_with_method_injection():
     class Interface(object):
         pass