Overflow parsing uint64

[nick-phillips-dev]

There isn't any error handling in this code: https://github.com/alecthomas/participle/blob/master/nodes.go#L302-L307

I'm trying to reject values larger than 2^64. When I add some logging in that block, I get this:

strconv.ParseUint: parsing "18446744073709551616": value out of range

However, the value I get is 1 with no parsing errors.

[alecthomas]

Ah, huh. Definitely needs a few failf calls in there.

[incognick]

I can make a PR if that will help. Would just need some direction.

[alecthomas]

That would be appreciated.

It just needs calls to panicf() in an else clause for each one.

If you don't get to it I will soonish.

[alecthomas]

Actually after taking a bit of a closer look I realised this is (somewhat) deliberate. If Participle encounters non-numeric tokens being captured into numeric fields it treats the field as a counter and increments it. That is useful for certain types of grammar features. On the other hand, it is also very confusing when you don't want that behaviour.

I think I will remove that feature. It can be replicated with a custom Capture implementation anyway.