Rule Proposal: warn if # is used in by.id locators

[alecxe]

Example of a violation:

element(by.id('#1484755825715-7-uiGrid-0007-cell'));

Correct usage:

element(by.id('1484755825715-7-uiGrid-0007-cell'))

[eLRuLL]

let me take this, do you have a recommendation for the rule name?

[alecxe]

@eLRuLL sure!

One idea is to have a general valid-by-id and check not only for # but for overall proper id attribute value (reference).

Another, is to keep this rule simple - no-hash-in-by-id?

What do you think? Thanks.

[eLRuLL]

I honestly think we should approach this as valid id (so valid_by_id) with a regex to match html4 rule:

ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods (".").

[robinj]

@eLRuLL ignore my previous post. I think you are right. It makes more sense to have that rather than potentially adding many rules to cover all invalid cases.

[alecxe]

@robinj @eLRuLL sounds great, let's cover the general id validness. Thanks.

[alecxe]

@eLRuLL thanks for the pull request!