Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Style Standard #1

Open
benni347 opened this issue Dec 6, 2023 · 3 comments
Open

Coding Style Standard #1

benni347 opened this issue Dec 6, 2023 · 3 comments

Comments

@benni347
Copy link

benni347 commented Dec 6, 2023

Hey, I would recommend you use coding standards for python that would be pep8, you have some constants in your code which should all be in uppercase.

And I would also recommend you use a formatter, I would recommend ruff.

@aledog007
Copy link
Owner

Okay, thanks I appreciate that

@aledog007
Copy link
Owner

I have just made a mistake with the commit if I find time I will make all constants uppercase and look at everything XD

@benni347
Copy link
Author

benni347 commented Dec 6, 2023

Another small thing the lambda function should be replaced with a def keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants