Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Missing keywords #137

Closed
TheWitheredStriker opened this issue Jul 7, 2023 · 2 comments · Fixed by #138
Closed

[FEATURE] - Missing keywords #137

TheWitheredStriker opened this issue Jul 7, 2023 · 2 comments · Fixed by #138

Comments

@TheWitheredStriker
Copy link
Contributor

As described in #135. The following keywords are not currently highlighted by the grammar:

  • assembler
  • cdecl
  • cppdecl
  • constref
  • helper
  • nostackframe
  • oldfpccall
  • pascal
  • register
  • stdcall

I am creating a PR as we speak and will link it to this issue per the contribution guidelines.

Also missing from the highlighters are several keywords offered by another Pascal variant known as Oxygene (which uses e.g. namespace instead of unit, and method to define functions), but that's a different can of worms, and mainly relevant if this repo were to be used as new Pascal syntax highlighter for GitHub (see, again, issue 135). So I'll leave that for later discussion.

@alefragnani
Copy link
Owner

Hi @TheWitheredStriker ,

I played a bit with Oxygene back in the days when RemObjects were providing it as part of Delphi .NET, and it was quite promising TBH, as I would like to embrace the .NET ecosystem. But since they split relationship with Embarcadero, and no free product were available to play, I simply moved away.

So yes, the extension could be used to Oxygene as well (it certainly could already be, if they had a free tier product for me to play. You are free to open a PR with missing keywords, for sure.

Thank you

@TheWitheredStriker
Copy link
Contributor Author

Very well! Consider it done. Making a PR for Oxygene asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants