Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build warnings. #51

Merged
merged 2 commits into from Apr 4, 2016
Merged

Remove build warnings. #51

merged 2 commits into from Apr 4, 2016

Conversation

dboyliao
Copy link

@dboyliao dboyliao commented Apr 3, 2016

Remove warnings when building with XCode by:

  • change typealias declared in protocols to associatedtype
  • fix var parameter. var parameter is deprecated.

@dboyliao
Remove build warnings (typealias declared in protocol will be depreca…
7164d0d 
…ted. var parameter will be deprecated). Tests pass.
@dboyliao
Copy link
Author

dboyliao commented Apr 3, 2016

Hhmmm...
Seems like the swift on Travis does not know associatedtype?

@alejandro-isaza
Copy link
Owner

We need osx_image: xcode7.3 in .travis.yml

@dboyliao
Copy link
Author

dboyliao commented Apr 3, 2016

Ok, let's see how it work.

@dboyliao
Copy link
Author

dboyliao commented Apr 3, 2016

Great, it's ready to go. : )

@alejandro-isaza alejandro-isaza merged commit 915b7cb into alejandro-isaza:master Apr 4, 2016
@dboyliao dboyliao deleted the removeWarnings branch April 7, 2016 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dboyliao @alejandro-isaza