Fixed broken drawPlaceholder function and length check on strings #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Strings. Additionally removed a .DS_Store file from the Repo
NikoGenn
suggested changes
May 23, 2017
| @@ -10,104 +10,104 @@ import UIKit | |||
|
|
|||
| @IBDesignable | |||
| open class AwesomeTextField: UITextField { | |||
|
|
|||
There was a problem hiding this comment.
Please, remove trailing whitespaces on blank lines.
The rest looks good to merge
|
@NikoGenn Done, thanks 👍 |
NikoGenn
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to character count on strings instead of length check (swift 3.1)
source : https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/StringsAndCharacters.html#//apple_ref/doc/uid/TP40014097-CH7-ID297