Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is IObject::instanceSourcePath() not const? #114

Closed
sybrenstuvel opened this issue Feb 23, 2017 · 2 comments
Closed

Why is IObject::instanceSourcePath() not const? #114

sybrenstuvel opened this issue Feb 23, 2017 · 2 comments
Assignees
@lamiller0
Milestone
1.7.1

Comments

@sybrenstuvel
Copy link
Contributor

The member function IObject::instanceSourcePath() is declared as non-const. However, from the description it doesn't seem to actually modify the IObject. Looking at its implementation it doesn't do much more than possibly create some shared pointers and read some data; nothing seems to modify the object state.

Couldn't it be a const function instead?
@lamiller0
Copy link
Contributor

Yes, this looks like it can be const.

@lamiller0 lamiller0 self-assigned this Feb 28, 2017
@lamiller0 lamiller0 added this to the 1.7.1 milestone Feb 28, 2017
@lamiller0
Copy link
Contributor

Released in 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamiller0 lamiller0

Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
2 participants
@sybrenstuvel @lamiller0