Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Typescript SDK is not compatible with the runtime Nodejs 12 #255

Open
hoh opened this issue Dec 8, 2022 · 1 comment · May be fixed by #252
Open

The Typescript SDK is not compatible with the runtime Nodejs 12 #255

hoh opened this issue Dec 8, 2022 · 1 comment · May be fixed by #252

Comments

@hoh
Copy link
Member

hoh commented Dec 8, 2022 •
edited
Loading

Describe the bug

The Typescript SDK is incompatible with the current runtime since only Nodejs 12 is provided - and the SDK requires a more recent version.

We should install a recent version of Nodejs when creating the runtime rootfs instead of using the version provided by Debian 11 Bullseye.

Installing it from Nodesource looks like a recommended approach:
https://github.com/nodesource/distributions/blob/master/README.md
@hoh
Copy link
Member Author

hoh commented Dec 8, 2022

This may be enough:

diff --git a/runtimes/aleph-debian-11-python/create_disk_image.sh b/runtimes/aleph-debian-11-python/create_disk_image.sh
index 7fbb620..c6a10e8 100755
--- a/runtimes/aleph-debian-11-python/create_disk_image.sh
+++ b/runtimes/aleph-debian-11-python/create_disk_image.sh
@@ -22,7 +22,6 @@ apt-get install -y --no-install-recommends --no-install-suggests \
   python3-setuptools \
   python3-pip python3-cytoolz python3-pydantic \
   iproute2 unzip \
-  nodejs npm \
   build-essential python3-dev
 
 pip3 install 'fastapi~=0.71.0'
@@ -33,6 +32,10 @@ pip3 install 'aleph-client>=0.4.6' 'coincurve==15.0.0'
 # Compile all Python bytecode
 python3 -m compileall -f /usr/local/lib/python3.9
 
+# Install Nodejs 18
+curl -fsSL https://deb.nodesource.com/setup_18.x | bash -
+apt-get install -y nodejs
+
 echo "root:toor" | /usr/sbin/chpasswd
 
 mkdir -p /overlay

@BjrInt BjrInt linked a pull request Dec 10, 2022 that will close this issue
Add an example for Node.js #252
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an example for Node.js aleph-im/aleph-vm
1 participant
@hoh