Suite of fixes & improvements in stats calculation and Anchor support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Added generic typification to AccountTimeSeriesStatsManager Problem: Time frame stats would miss entries or break down on singular events, resulting in wrong time series calculation Solution: Fix issues for edge cases in splitDurationIntoIntervals() Problem: Anchor-generated indexers would not correctly aggregate accesses to programs Solution: Add "signer" field to all events, denoting the pubkey of the first signer, initiating a transaction Problem: Anchor-generated indexers do not work well with current InstructionParser Solution: Created two distinctive InstructionParsers (Anchor- and Spl-) and make a split decision between which to use in the InstructionParserLibrary Problem: Certain RPC providers do not accept batch sizes of >100 Solution: Halve batch sizes across the board
|
Needs some more fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Missing type safety made debugging difficult
Solution: Added generic typification to AccountTimeSeriesStatsManager
Problem: Time frame stats would miss entries or break down on singular events, resulting in wrong time series calculation Solution: Fix issues for edge cases in splitDurationIntoIntervals()
Problem: Anchor-generated indexers would not correctly aggregate accesses to programs Solution: Add "signer" field to all events, denoting the pubkey of the first signer, initiating a transaction
Problem: Anchor-generated indexers do not work well with current InstructionParser Solution: Created two distinctive InstructionParsers (Anchor- and Spl-) and make a split decision between which to use in the InstructionParserLibrary
Problem: Certain RPC providers do not accept batch sizes of >100
Solution: Halve batch sizes across the board