Hotfix: Request legacy txn format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
# Conflicts: # package-lock.json
use v0, as no breaking changes are being introduced for the indexer
|
Tried and tested this. Fetched transactions work still fine, as v0 transactions have all the properties of legacy transaction + some info about the lookup tables, which are not being indexed by us. All addresses are listed as expected from "legacy". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The new version of Solana RPC nodes returns the new transaction v0 format by default, which we do not yet support.
Solution: A workaround explicitly requesting transactions in the 'legacy' format.
Note to Aleph team: Will not immediately fix requests through the HA proxy.
EDIT: v0 transactions should be no issue for current indexer framework