Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: RPCresponse validation flag & tests, also included some in-code documentation #9

Merged
merged 9 commits into from Nov 16, 2022

Conversation

ricardocr987
Copy link
Contributor

Used the same library as solana web3 library (superstruct), but changed the method they use create (for example: https://github.com/solana-labs/solana-web3.js/blob/master/src/connection.ts#L4094) for assert, because they apart of validate the response, they process it, to change some strings to publickey directly during the validation (which we dont want to).

Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's a little bit mixed in what has been done in the PR, but as all these changes won't influence current production code, as far as I can see, it should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants