Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should change text colour on blue buttons #16

Closed
Kevin8675 opened this issue Dec 29, 2021 · 7 comments
Closed

Should change text colour on blue buttons #16

Kevin8675 opened this issue Dec 29, 2021 · 7 comments

Comments

@Kevin8675
Copy link

Kevin8675 commented Dec 29, 2021

Currently all the buttons (install/cancel) have black text. The Install button (or any button that has a blue background) should have a more bright text (probably white) as the text is not really noticeable.
image

@Kevin8675 Kevin8675 changed the title Should change text colour under nlue button Should change text colour on blue buttons Dec 29, 2021
@alesimula
Copy link
Owner

alesimula commented Jan 6, 2022

@Kevin8675 A different text color on an adjacent button would look weird, but I'm considering using a lighter accent color for light mode, what do you think?

image
^ Before

image
^ After

@Kevin8675
Copy link
Author

@alesimula This colour looks a lot better in my opinion.

@alesimula
Copy link
Owner

alesimula commented Jan 6, 2022

@Kevin8675 Here is a test version if you want to try it (the "WsaClient path" text paragraph is related to another issue I'm testing, won't be in the final version);

You can compare it to the old portable version if you want, the settings change in real time

@Kevin8675
Copy link
Author

@alesimula I just installed the test version and it looks great! Another minor design issue is that in the settings menu, the switches for autostart and icons are not lined up vertically.
image
Even though there is an arrow for the icons, I think the switches should line up.

@alesimula
Copy link
Owner

alesimula commented Jan 6, 2022

@Kevin8675 I was trying to follow the Windows settings' fluent UI choices, but I personally think it would look worse if there was a blank space after the trailing button

image

image

@Kevin8675
Copy link
Author

Ah I see, makes sense.

@alesimula
Copy link
Owner

@Kevin8675 change released in new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants