Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground vsgraphiql option #10

Open
kgajowy opened this issue May 23, 2019 · 1 comment
Open

Playground vsgraphiql option #10

kgajowy opened this issue May 23, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kgajowy
Copy link

kgajowy commented May 23, 2019

Hello there!

Thank you very much, I was about to write very similar stuff for Admin Panel purpose (will most likely publish ra-data-postraphile pkg as well)

as wiki mentions: playground (optional): set this to true to enable the Playground interface (Defaults to false) - for me this does not work. However, using "native" option graphiql: true takes correct effect - but only if provided together with playground. This is rather strange effect, not sure if desired or has any practical reasons.
I just noticed that if playground and graphiql are both true, both paths are available. I believe it should be consistent with postrgraphi and keep original route instead of playground 🤔

Would be happy to assist in "fixing" (or documenting) this is you can drop any hint.

Thanks!

@kgajowy kgajowy changed the title Playground options has no effect Playground options has no effect without graphiql May 23, 2019
@kgajowy kgajowy changed the title Playground options has no effect without graphiql Playground vsgraphiql option May 23, 2019
@alex-ald
Copy link
Owner

alex-ald commented Jun 4, 2019

@kgajowy Hi! At the time I started this project, I was really in favor for playground instead of graphiql. With this in mind, I simply added playground to the project while still keeping postgraphile's graphiql. This means both dev tools can be used at the same time. I am in favor of disabling postgraphile's graphiql. So I encourage you to create a PR for this! :)

@alex-ald alex-ald added good first issue Good for newcomers enhancement New feature or request labels Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants