Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Implement Extended Query PostgreSQL Protocol #177

Closed
alex-dukhno opened this issue Jul 13, 2020 · 1 comment · Fixed by #274
Closed

Implement Extended Query PostgreSQL Protocol #177

alex-dukhno opened this issue Jul 13, 2020 · 1 comment · Fixed by #274
Assignees
Labels
C-Protocol PostgreSQL Wire Protocol help wanted Extra attention is needed P-High High priority T-Enhancement New feature or request

Comments

@alex-dukhno
Copy link
Owner

alex-dukhno commented Jul 13, 2020

If I were asked to describe what is "Extended Query PostgreSQL Protocol", I'd say it is Prepared Statement over wire.
As far as I understand (right now) query is sent in form of the string like select * from table where col1 = $1; or insert into table values ($1, $2, $3); and then data bindings negotiated between client and server.

Doc https://www.postgresql.org/docs/12/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY

Quick search over Materialize source code gave me https://github.com/MaterializeInc/materialize/blob/main/src/pgwire/src/protocol.rs#L114 as possible entry point to start getting info of how "prepared statement" state could be managed

@alex-dukhno alex-dukhno created this issue from a note in Kanban Board (To do) Jul 13, 2020
@alex-dukhno alex-dukhno added C-Protocol PostgreSQL Wire Protocol help wanted Extra attention is needed P-High High priority T-Enhancement New feature or request labels Jul 13, 2020
@alex-dukhno alex-dukhno added this to the 0.1.2 milestone Jul 13, 2020
@silathdiir
Copy link
Contributor

silathdiir commented Jul 17, 2020

Hi @alex-dukhno , I'd like to work on this issue after PR #184 is reviewed and merged. Please assign it to me. Thanks.

@alex-dukhno alex-dukhno moved this from To do to In progress in Kanban Board Jul 18, 2020
@alex-dukhno alex-dukhno modified the milestones: 0.1.2, 0.1.3 Jul 22, 2020
@silathdiir silathdiir mentioned this issue Aug 8, 2020
3 tasks
@alex-dukhno alex-dukhno modified the milestones: 0.1.3, 0.1.4 Aug 29, 2020
Kanban Board automation moved this from In progress to Done Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Protocol PostgreSQL Wire Protocol help wanted Extra attention is needed P-High High priority T-Enhancement New feature or request
Projects
No open projects
Kanban Board
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants