Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Implement TLS connection support with PostgreSQL wire protocol #32

Closed
alex-dukhno opened this issue May 14, 2020 · 3 comments · Fixed by #169
Closed

Implement TLS connection support with PostgreSQL wire protocol #32

alex-dukhno opened this issue May 14, 2020 · 3 comments · Fixed by #169
Assignees
Labels
C-Protocol PostgreSQL Wire Protocol help wanted Extra attention is needed P-High High priority T-Enhancement New feature or request

Comments

@alex-dukhno
Copy link
Owner

alex-dukhno commented May 14, 2020

Some PoC is required to investigate is there any parts that should be extracted into protocol API and implemented by database backend.
As a code reference we can take a look at https://github.com/MaterializeInc/materialize/blob/master/src/pgwire/src/server.rs#L49

@alex-dukhno alex-dukhno added C-Protocol PostgreSQL Wire Protocol P-High High priority T-Enhancement New feature or request labels May 14, 2020
@alex-dukhno alex-dukhno added this to the 0.1.1 milestone May 23, 2020
@alex-dukhno alex-dukhno added this to To do in Kanban Board May 30, 2020
@alex-dukhno alex-dukhno modified the milestones: 0.1.1, Backlog Jun 6, 2020
@alex-dukhno alex-dukhno moved this from To do to Backlog in Kanban Board Jun 6, 2020
@alex-dukhno alex-dukhno added the help wanted Extra attention is needed label Jun 16, 2020
@alex-dukhno alex-dukhno added the S-Requires Description Description should be provided label Jun 25, 2020
@alex-dukhno alex-dukhno moved this from Backlog to Welcome contributors in Kanban Board Jun 28, 2020
@alex-dukhno alex-dukhno removed the S-Requires Description Description should be provided label Jun 28, 2020
@alex-dukhno alex-dukhno removed this from the Backlog milestone Jun 28, 2020
@silathdiir
Copy link
Contributor

Hi @alex-dukhno , I'd like to look into this issue. Please assign it to me.

@alex-dukhno alex-dukhno moved this from Welcome contributors to In progress in Kanban Board Jul 2, 2020
@alex-dukhno
Copy link
Owner Author

This one can be tricky. Materialize depends on tokio and its tls support (honestly, I haven't dig deep), and I'd like that protocol has least dependencies specially for async runtime.

@silathdiir also, as more people want to contribute I have created discord server https://discord.gg/PUcTcfU to have discussions there. So you might want to join. It would better to have a place to sync and easier to coordinate with others. Thanks

@silathdiir
Copy link
Contributor

silathdiir commented Jul 2, 2020

Hi @alex-dukhno , thanks for the information. I will try to look into it to check if we could implementing tls protocol doesn't depend on tokio.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Protocol PostgreSQL Wire Protocol help wanted Extra attention is needed P-High High priority T-Enhancement New feature or request
Projects
No open projects
Kanban Board
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants