Skip to content
This repository has been archived by the owner on Aug 10, 2018. It is now read-only.

Checkout comment not preserved under Emacs 24.5 #18

Open
plopresti opened this issue Nov 18, 2015 · 1 comment
Open

Checkout comment not preserved under Emacs 24.5 #18

plopresti opened this issue Nov 18, 2015 · 1 comment
Labels

Comments

@plopresti
Copy link

When I use "C-c v v" to check in, vc-clearcase used to populate the comment buffer with the checkout comment.

With Emacs 24.5, this comment is being erased and replaced by "Summary: ".

I have traced the behavior. First, the code in vc-clearcase-log-edit-mode runs and inserts the comment correctly (hooray!). But then, vc-log-edit invokes log-edit with the "setup" argument set to t. log-edit reacts by running (erase-buffer) followed by (run-hooks 'log-edit-hook).

I do not understand the logic that vc-log-edit uses to decide when the "setup" argument should be true, so I gave up and added this to my .emacs file:

(defun patlhack ()
;;; body of vc-clearcase-log-edit-mode here
)
(setq log-edit-hook 'patlhack)

Yes this is a huge hack, but it does appear to work around the problem.

I have no idea how to fix this "correctly".

@alex-hhh alex-hhh added the bug label Nov 18, 2015
@alex-hhh alex-hhh self-assigned this Nov 18, 2015
@alex-hhh
Copy link
Owner

Unfortunately I don't use this package anymore as I don't have access to a ClearCase installation...

However, looking at the code Emacs code, it seems that the setup argument is t when vc-log-fileset is different for the log buffer.

I think your fix, using a hook function is probably the best we can do. I will push a fix and let you know to try it out.

Best Regards,
Alex.

@alex-hhh alex-hhh removed their assignment Feb 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants