Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUESTION: Is the call to captureAWS via the aws-xray-sdk still required in v2.0? #14

Open
tafs7 opened this issue Jan 9, 2018 · 2 comments

Comments

@tafs7
Copy link

tafs7 commented Jan 9, 2018

I noticed that for v2.0, you added a comment at the top of the README which states this plugin now enables tracing via CloudFormation, instead of making calls to the AWS sdk.

However, a few lines later in the README, you state that we still need to include the following code:

const awsXRay = require('aws-xray-sdk');
const awsSdk = awsXRay.captureAWS(require('aws-sdk'));

Is that call to captureAWS still a requirement via code, or just a remnant of previous requirement before v2.0, and should be removed from the README?

@mrfishy
Copy link

mrfishy commented Jan 25, 2018

I'm not a developer with this project, but I just verified by experiment that the wrapper is still needed. The tracing enabled by this plugin add called TO this function to be shown in XRay. Wrapping the awsSdk as shown in the docs allows calls FROM this function to also be shown.

@alex-murashkin
Copy link
Owner

@tafs7 Sorry for the delay - I've been very busy lately and rarely check GitHub issues list.
Thanks @mrfishy for filling in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants