Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate rolling time extension from lifetime #52

Closed
RamiAwar opened this issue Sep 17, 2022 · 1 comment
Closed

Separate rolling time extension from lifetime #52

RamiAwar opened this issue Sep 17, 2022 · 1 comment

Comments

@RamiAwar
Copy link
Contributor

First of all, super impressed by all the work you did since a couple of months, that's insane! Still trying to read through the changes.

Do you think it makes sense to provide two config values for the session middleware? In my use case, I'd like to give a session lifetime of 1 day, but if the user happens to be mid-session and near that deadline, then I'd want to extend his session by 5 minutes just so we don't cut them off. But after 5 minutes they're auto-logged out.

Right now the extension would be for another full day which is too permissive maybe.

@alex-oleshkevich
Copy link
Owner

This is a very specific use case, I am not sure if someone else could want it. Another argument will add an extra complexity to the middleware.

I would recommend you to go with short living rolling sessions and see how it fits your needs.

@alex-oleshkevich alex-oleshkevich closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants