Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos (or Gifs) for README #223

Closed
alex-petrenko opened this issue Oct 28, 2022 · 5 comments
Closed

Videos (or Gifs) for README #223

alex-petrenko opened this issue Oct 28, 2022 · 5 comments
Assignees

Comments

@alex-petrenko
Copy link
Owner

@edbeeching it looks like Github's own Markdown renderer does not support <video>
Do you think we could make a set of Gifs that demonstrate some of the more interesting environments? I'm thinking Atari, Vizdoom, DMLab, Mujoco, IsaacGym locomotion and manipulation

Let me know what you think

@edbeeching
Copy link
Collaborator

@alex-petrenko There is a sneaky way to do this. If you edit the readme in browser and drag and drop a video, it will embed it.

For example:

isaacgymgrid_grid_4.mp4

@alex-petrenko
Copy link
Owner Author

Wow! A game changer :)

@alex-petrenko
Copy link
Owner Author

@edbeeching I tried adding Atari video (see at the end of Readme on sf2 branch), and it works, but there does not seem to be any way to control it's size or layout, or use autoplay/looping... I think maybe we should stick to Gifs for now as long as they're not very big?

@edbeeching
Copy link
Collaborator

Ah ok, let's stick with GIFs. Perhaps there are clever ways to format / tile the videos. But I agree that the simplest is to use a gif.

@alex-petrenko
Copy link
Owner Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants