New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Travis or another CI system #11
Comments
I agree, unfortunately the time investment on this at the moment I think would not pay out. One giant issue standing in the way is that a fair number of the unit tests I've written will fail by dead locking and I haven't set timeouts on anything. I think this is great for blue sky, especially if more people begin contributing, but for the moment I'll just leave this open as a "nice to have". |
I had run test suite for ~500 times in a shell script on my machine. It seems to be stable, no errors happened. What tests do you suspect to be dead locking? |
I don't mean that the tests fail in a non-deterministic way, but when they do fail rather than the test getting marked as a failure, the test will just not complete. For instance, if you comment out the two lines below https://github.com/alex-sherman/unsync/blob/master/unsync/unsync.py#L105 the test that verifies that will, rather than reporting a failure, never complete. |
Just as an idea: if you're using pytest as the test executor, pytest timeout may provide a simple way to break in case something hangs for a period of time. Moreover, travis or whatever also have configurable timeouts for steps. That doesn't give the nicest results for test reporting, but is ok to detect that something bad has happened. |
It would be nice to see in pull requests if tests are failing or passing.
The text was updated successfully, but these errors were encountered: