Add Classbased generic view and Fix "'test_book" table is not found" issue on test #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add classbased generic view called 'FilterView' to 'django_filters.generic.classbased' module and move functional 'object_filter' view to 'django_filters.generic.functional' module. These view are linked in 'views' module so you can use 'django_filters.views.object_filter' or 'django_filters.views.FilterView'. Add test for classbased generic view and fix a lot of issue for testing django_filters. Now you can test django_filters with any Django app because when testing, django_filters automatically add 'django_filters.tests' to installed_apps so no more 'test_book table is not found' issue! Fix Date depends test issue as well. Some docstring test depends on the date test executed.
|
I think this needs a few tweaks, will try to properly review soon. |
|
Hmm, just make sure there are no license issues, I am surely not commiting this code with the apache license header ;) |
nkryptic
added a commit
to nkryptic/django-filter
that referenced
this pull request
Jan 20, 2013
…mbdalisue * based upon Django's ListView * docs updated and deprecate `object_filter` functional view * `object_filter` is now basically a wrapper for the CBV * added a `filterset_factory` to filterset.py
|
Was fixed as part of #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add classbased generic view called
FilterViewtodjango_filters.generic.classbasedmodule and move functional generic view calledobject_filtertodjango_filters.generic.functionalmodule. These view are linked indjango_filters.viewsmodule so you can usedjango_filters.views.object_filterordjango_filters.views.FilterView.Add test for classbased generic view and fix a lot of issue for testing
django_filters. Now you can test django_filters with any Django app
because when testing, django_filters automatically add
django_filters.teststoINSTALLED_APPSso no more 'test_book table isnot found' issue!
Fix Date depends test issue as well. Some docstring test depends on the
date test executed.