New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case-insensitive option for tag names. #263

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@qris

qris commented Sep 15, 2014

I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the unique constraint on tag name:

IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, TAGGIT_CASE_INSENSITIVE, which causes existing tags to be looked up case insensitively. New tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without this setting.

This meets nookiepl's request on #70, and my comment on #9.

Add case-insensitive option for tag names.
I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the
unique constraint on tag name:

    IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, `TAGGIT_CASE_INSENSITIVE`, which causes existing tags to be looked up case insensitively. New
tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without
this setting.

This meets nookiepl's request on #70, and my comment on #9.
@buddylindsey

This comment has been minimized.

Show comment
Hide comment
@buddylindsey

buddylindsey Sep 26, 2014

+100000000000 We just hit this issue. :(

buddylindsey commented Sep 26, 2014

+100000000000 We just hit this issue. :(

@buddylindsey

This comment has been minimized.

Show comment
Hide comment
@buddylindsey

buddylindsey Oct 28, 2014

Just circling back. This looks like one of the better solutions for this, but it looks like a lot of people are hitting this issue all these PR's are trying to solve the same problem.
#98 #220 #263 #270 #274

buddylindsey commented Oct 28, 2014

Just circling back. This looks like one of the better solutions for this, but it looks like a lot of people are hitting this issue all these PR's are trying to solve the same problem.
#98 #220 #263 #270 #274

@ivancrneto

This comment has been minimized.

Show comment
Hide comment
@ivancrneto

ivancrneto Dec 26, 2014

+1 for this, I tried to solve the problem in another PR but this solution is much better

ivancrneto commented Dec 26, 2014

+1 for this, I tried to solve the problem in another PR but this solution is much better

@frewsxcv

This comment has been minimized.

Show comment
Hide comment
@frewsxcv

frewsxcv Mar 29, 2015

Collaborator

@qris Can you fix the merge conflicts here? I can merge afterwards

Collaborator

frewsxcv commented Mar 29, 2015

@qris Can you fix the merge conflicts here? I can merge afterwards

mfeliu pushed a commit to mfeliu/django-taggit that referenced this pull request Jul 1, 2015

Marco A. Feliú
Add case-insensitive option for tag names.
This commit was adapted from a unmerged pull request [#263](alex#263) done by [qris](https://github.com/qrisa). The following text is his original commit message:

Add case-insensitive option for tag names.

I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the
unique constraint on tag name:

    IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, `TAGGIT_CASE_INSENSITIVE`, which causes existing tags to be looked up case insensitively. New
tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without
this setting.

This meets nookiepl's request on #70, and my comment on #9.

mfeliu pushed a commit to mfeliu/django-taggit that referenced this pull request Jul 1, 2015

Marco A. Feliú
Add case-insensitive option for tag names.
This commit was adapted from an unmerged pull request [#263](alex#263) done by [qris](https://github.com/qrisa). The following text is his original commit message:

Add case-insensitive option for tag names.

I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the
unique constraint on tag name:

    IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, `TAGGIT_CASE_INSENSITIVE`, which causes existing tags to be looked up case insensitively. New
tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without
this setting.

This meets nookiepl's request on #70, and my comment on #9.

mfeliu added a commit to mfeliu/django-taggit that referenced this pull request Jul 1, 2015

Add case-insensitive option for tag names.
This commit was adapted from an unmerged pull request [#263](alex#263) done by [qris](https://github.com/qrisa). The following text is his original commit message:

Add case-insensitive option for tag names.

I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the
unique constraint on tag name:

    IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, `TAGGIT_CASE_INSENSITIVE`, which causes existing tags to be looked up case insensitively. New
tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without
this setting.

This meets nookiepl's request on #70, and my comment on #9.
@mfeliu

This comment has been minimized.

Show comment
Hide comment
@mfeliu

mfeliu Jul 3, 2015

Contributor

Hi, I have fixed the merged conflicts in another pull request: #325

Could you merge it please?

Contributor

mfeliu commented Jul 3, 2015

Hi, I have fixed the merged conflicts in another pull request: #325

Could you merge it please?

mfeliu added a commit to mfeliu/django-taggit that referenced this pull request Jul 4, 2015

Add case-insensitive option for tag names.
This commit was adapted from an unmerged pull request [#263](alex#263) done by [qris](https://github.com/qrisa). The following text is his original commit message:

Add case-insensitive option for tag names.

I don't think it makes sense to have tags which differ only in case. It's not even possible on MySQL because it violates the
unique constraint on tag name:

    IntegrityError: (1062, "Duplicate entry 'LONDON' for key 'taggit_tag_name_6b48d50f_uniq'")

This PR adds a new setting, `TAGGIT_CASE_INSENSITIVE`, which causes existing tags to be looked up case insensitively. New
tags are added with the supplied case, which will be used from then on. The default behaviour is the same as before without
this setting.

This meets nookiepl's request on #70, and my comment on #9.
@frewsxcv

This comment has been minimized.

Show comment
Hide comment
@frewsxcv

frewsxcv Jul 4, 2015

Collaborator

Case insensitive tags was added in #325 and is available in the latest version of taggit (0.16.0)

Collaborator

frewsxcv commented Jul 4, 2015

Case insensitive tags was added in #325 and is available in the latest version of taggit (0.16.0)

@frewsxcv frewsxcv closed this Jul 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment