Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TagWidget for Django 2.1 #534

Merged
merged 1 commit into from Aug 5, 2018
Merged

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Aug 2, 2018

Proposed alternative fix to #505, which preserves the behaviour of the renderer kwarg.

format_value is a more suitable place for converting the value - this way we're sidestepping the need to deal with any current or future changes to Django's render logic.

(Unfortunately the Django <1.10 fallback code makes it pretty ugly, but hopefully that won't be there forever :-) )

@jdufresne
Copy link
Member

The project has dropped support for Django <= 1.10. Would you like to rebase this change to account for that?

@gasman
Copy link
Contributor Author

gasman commented Aug 5, 2018

@jdufresne Sure - rebased now. (Obviously, with #518 merged this change isn't really necessary any more, but I think performing the conversion in format_value is stylistically neater anyhow...)

@codecov-io
Copy link

codecov-io commented Aug 5, 2018

Codecov Report

Merging #534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           5        5           
  Lines         509      509           
  Branches       85       85           
=======================================
  Hits          447      447           
  Misses         49       49           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568a0bd...9331ae1. Read the comment docs.

@jdufresne jdufresne merged commit 7ada5bc into jazzband:master Aug 5, 2018
@jdufresne
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants