Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync (Google Sync / Profile Sync) missing on clean portable version (.zip) M111.0.5563.111 WIN64 #43

Closed
maxwowpow opened this issue Apr 13, 2023 · 11 comments

Comments

@maxwowpow
Copy link

maxwowpow commented Apr 13, 2023

Used a portable version with flags
--disable-encryption --disable-machine-id

In the latest version there is no sync / login function.

On MAC it works (no extra flags)

Vanilla extracted from .zip. Started THORIUM.BAT

Not sure to had seen somewhere, that sync works when encryption enabled? b. On windows no sync possible c. API keys changed or smth?

UPD:
There is an avx2 build, so if you've a modern cpu, give that a try:
https://github.com/Alex313031/Thorium-AVX2/releases

@k3bc999
Copy link

k3bc999 commented Apr 15, 2023

It looks like the latest version (M111.0.5563.111) does not include Google Sync

@gz83
Copy link
Collaborator

gz83 commented Apr 17, 2023

@maxwowpow @k3bc999

Local testing cannot reproduce the problems you are experiencing.

Please try to remove -disable-encryption and -disable-machine-id before trying to use the related features.

@maxwowpow
Copy link
Author

without flags and clean run same behavior.
Version 111.0.5563.111 (Official Build) (64-bit)
@gz83 your version same on win10 64bit?

@gz83
Copy link
Collaborator

gz83 commented Apr 18, 2023

@maxwowpow

I'm using Win11 x64, also, this version of Thorium was compiled by me and we have tested it before releasing it.
Please try uninstalling the browser and reinstalling it, then try using the sync feature again.

@maxwowpow
Copy link
Author

maxwowpow commented Apr 18, 2023

It's about the portable version (Releases / Assets / .zip), not the installable one. Running the cmd THORIUM.BAT

@gz83
Copy link
Collaborator

gz83 commented Apr 18, 2023

@maxwowpow

Has the path to the user data folder inside the THORIUM.BAT file been modified?

Also, is it convenient to provide a screenshot of the top right corner of the main interface and a screenshot of the chrome://settings/people page?

@maxwowpow
Copy link
Author

maxwowpow commented Apr 19, 2023

The path was not modified:
--user-data-dir="%~dp0%\USER_DATA"

image

image

tried a new profile / testing right after unpacking as well.
Is there a debug mode / verbose logging switch or similar?

You never know what env vars, reg keys, firewall settings are being checked. There must be some if's in the code to show the sync button.

@maxwowpow maxwowpow changed the title Sync (Google Sync / Profile Sync) Sync (Google Sync / Profile Sync) missing on portable (.zip) M111.0.5563.111 WIN64 Apr 19, 2023
@maxwowpow maxwowpow changed the title Sync (Google Sync / Profile Sync) missing on portable (.zip) M111.0.5563.111 WIN64 Sync (Google Sync / Profile Sync) missing on clean portable version (.zip) M111.0.5563.111 WIN64 Apr 19, 2023
@gz83
Copy link
Collaborator

gz83 commented Apr 19, 2023

@maxwowpow

Sync is available on my end, you can check the other issue I linked to inside this one.

Also, the thorium development team is preparing to update the repo to version M112, and we will investigate this issue during the update process.

@k3bc999
Copy link

k3bc999 commented Apr 19, 2023

I used the installer for a fresh install (M111), but it only exists for local accounts, and there is no button to enable syncing when I click on the user image in the browser.
After uninstalling and using the old version (M110), it syncs correctly, but after upgrading from M110 to M111, although the bookmarks and extensions are still there, the account also changes to local
It should be noted that the avx2 version of M111 Google Sync is working fine, which is really strange

@maxwowpow
Copy link
Author

maxwowpow commented Apr 19, 2023

Confirmed the sync works on the win avx2 build/version.
I'm switching to it, because apparently it makes sense if the cpu supports avx2 and as I didn't know about that build, it classifies as an acceptable workaround in my case. Thank you. ps. Feel free to ping me for a 112 test, apart from that, I'll mute the thread. Cheers.

@Alex313031
Copy link
Owner

@maxwowpow @k3bc999 Sorry guys, I actually forgot to put the API Keys in for that build. ANyway, the latest builds should have sync working.

However, note that the --disable-encryption seems to break sync because of security reasons. You don't want your google credentials just sitting in a plaintext file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants