Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorium AVX2 compilation error with -ffast-math #32

Closed
jessy-lua opened this issue May 22, 2022 · 5 comments
Closed

Thorium AVX2 compilation error with -ffast-math #32

jessy-lua opened this issue May 22, 2022 · 5 comments

Comments

@jessy-lua
Copy link

Building on the Windows vs2019

../../third_party/opus/src/celt\arch.h(203,2): error: Cannot build libopus with -ffast-math unless FLOAT_APPROX is defined. This could result in crashes on extreme (e.g. NaN) input
#error Cannot build libopus with -ffast-math unless FLOAT_APPROX is defined. This could result in crashes on extreme (e.g. NaN) input
 ^
1 error generated.
@Alex313031
Copy link
Owner

Alex313031 commented May 22, 2022

@jessy-lua Did you modify the main build.gn and try to add -ffast-math.

@Alex313031 Alex313031 reopened this May 22, 2022
@Alex313031 Alex313031 changed the title Can't build chromium AVX2 Thorium AVX2 compilation error with -ffast-math May 22, 2022
@jessy-lua
Copy link
Author

@jessy-lua Did you modify the main build.gn and try to add -ffast-math.

didn't modify anything

@jessy-lua
Copy link
Author

this issue presents only when i compiling with AVX2 build folder. tried two times

@Alex313031
Copy link
Owner

@jessy-lua What CPU is your build system using.

@jessy-lua
Copy link
Author

@jessy-lua What CPU is your build system using.

Intel 12th gen i9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants