New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only replace secrets.yaml if passwords are found in Bitwarden #18
Comments
Hi, thanks for the feedback and creating the issue. As a matter of fact, I recently migrated to a larger SSD and encountered the same issue!
Perhaps that would be possible with the Home Assistant
This functionality is currently implemented in version 1.3.0 (efb28ce) in an effort to mitigate the issue you are describing. So I really like to know if you were using this version of the add-on when this issue occurred? |
Hi Alex, In my logs I see also the following lines:
Maybe that's the issue? |
Don't worry. I haven't forgot about this issue. Things were rather busy for me, sorry for not responding.
The issue is that my script doesn't check whether or not Perhaps unrelated to this issue, but you can enable |
No problem. I will wait. |
@ElVit The PR automatically closed this issue. But I would really like it if you can test it and report back. I think the aforementioned PR solves this issue btw. If it doesn't I will of course re-open this issue. Basically I've added a check to test whether or not Bitwarden returns at least a single secret. Also I've changed the boot order so that this add-on will start after Home Assistant. That would probably also help a bit. |
@alex3305 There are only two things which I found that may be improved:
|
Hi,
I tried your Addon Bitwarden secrets for Home Assistant and I like it a lot.
But last time I restarted my Intel Nuc something went wrong and Home Assistant started in safe mode because the secrets.yaml was empty. Maybe it’s because Bitwarden started to late and your addon could not get the passwords. After I restarted just Home Assistant all worked fine.
Is there a possibility to check if Bitwarden is completely loaded before your addon gets the secrets?
Or maybe only rewrite the secrets.yaml file if there is really a password found in Bitwarden?
The text was updated successfully, but these errors were encountered: