Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior for undefined AudioPlayer event handler #105

Closed
fremail opened this issue Dec 31, 2016 · 3 comments
Closed

Wrong behavior for undefined AudioPlayer event handler #105

fremail opened this issue Dec 31, 2016 · 3 comments

Comments

@fremail
Copy link
Contributor

fremail commented Dec 31, 2016

If you don't set event handlers for all AudioPlayer events, the skill will fail because the app will end silently.

It should return even an empty response (without directives). So answer response.send(); would be enough instead of throwing an exception.

I'm not able to post additional data now.

Happy New Year! ^__^

@fremail fremail mentioned this issue Dec 31, 2016
@dblock dblock added the bug? label Dec 31, 2016
@dblock
Copy link
Collaborator

dblock commented Dec 31, 2016

Looks like a legit problem in need of a test and a fix ;)

trayburn referenced this issue in trayburn/alexa-app Jan 2, 2017
@trayburn
Copy link
Contributor

trayburn commented Jan 2, 2017

PR created that proves and fixes this behavior. Now responds with a simple (no directives or speech) response, on a promise which is fulfilled. Should be more than sufficient to satisfy Amazon's expectations of handling AudioPlayer events.

@dblock dblock closed this as completed in d7c0641 Jan 2, 2017
@dblock
Copy link
Collaborator

dblock commented Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants