Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiStream] data.CANNOT_SKIP_MSG missing #1

Closed
frivas opened this issue Dec 25, 2018 · 0 comments
Closed

[MultiStream] data.CANNOT_SKIP_MSG missing #1

frivas opened this issue Dec 25, 2018 · 0 comments

Comments

@frivas
Copy link

frivas commented Dec 25, 2018

Hello,

I was just checking this skill and going through the code I saw this:

class NextOrPreviousIntentHandler(AbstractRequestHandler):
    """Handler for next or previous intents."""
    def can_handle(self, handler_input):
        # type: (HandlerInput) -> bool
        return (is_intent_name("AMAZON.NextIntent")(handler_input) or
                is_intent_name("AMAZON.PreviousIntent")(handler_input))

    def handle(self, handler_input):
        # type: (HandlerInput) -> Response
        logger.info("In NextOrPreviousIntentHandler")
        _ = handler_input.attributes_manager.request_attributes["_"]
        handler_input.response_builder.speak(
            _(data.CANNOT_SKIP_MSG)).set_should_end_session(True)
        return handler_input.response_builder.response

What I had found odd was the in data.py there is no CANNOT_SKIP_MSG. Am I missing something here?.

Thank you very much in advanced.

[Update]: I can see now. Just checked the same file and class in the SingleStream code and, because it is a radio, you cannot skip therefore that message should be there, however I am afraid that for podcasts it should be possible to play next and previous episodes, right?. Thanks again.

[Update#2]: Just saw there is a verification of a playback session for the AMAZON.NextIntent and AMAZON.PreviousIntent , when there is a play back session then it is possible to play next and previous. Thanks again :D

@frivas frivas closed this as completed Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant