Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative sampling #1

Closed
TGDivy opened this issue Jul 9, 2020 · 0 comments
Closed

Negative sampling #1

TGDivy opened this issue Jul 9, 2020 · 0 comments

Comments

@TGDivy
Copy link

TGDivy commented Jul 9, 2020

Hi,
In the dataset file for the baseline,
line 128.
knowledge_key = "{}__{}__{}".format(knowledge["domain"], knowledge["entity_id"], knowledge["doc_id"]) # find snippets with same entity as candidates prefix = "{}__{}".format(knowledge["domain"], knowledge["entity_id"])
I think the code might be intended to select knowledge snippet from a specific document. I.e. if the label was hotel__1__15, then to select all hotel__1__. However, because of the code it also ends up selecting documents like hotel__11__, hotel__12__*, etc. This could potentially be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant