Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skill-id option not recognizing legacy skill pattern #489

Merged
merged 1 commit into from Aug 9, 2023

Conversation

CamdenFoucht
Copy link
Contributor

Description of changes:

  • Updated the skill-id regex to match the legacy skill-id pattern amzn1.echo-sdk-ams.app.1234abcd-12ab-abcd-1234-123456789012along with current patterns.
  • Removed unused askx files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@doiron doiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CamdenFoucht CamdenFoucht merged commit 3a71908 into develop Aug 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants