Possible bug in config file

[dv-fenix]

Hi @aishwaryap

I was revisiting the code for the E.T. baseline and there seems to be a bug in the config file for training the model:

teach/src/teach/modeling/ET/alfred/config.py

Line 183 in 5554f02

detach_lang_emb = False

I believe it should be detach_lang_emb = True since we do not want to propagate the gradients through the look-up table or the language encoder.

Please let me know your thoughts on this.

Thanks,
Divyam

[aishwaryap]

Hi @dv-fenix for the TEACh paper, we are not doing any language pretraining so we do want the gradients to propagate through the language encoder. So this is the desired setting.

[dv-fenix]

Hi @aishwaryap

Thank you for the clarification!
For the sake of completion, can you clarify what the desired setting would be when training the E.T. baseline with a language encoder that has been pre-trained on synthetic language instructions from ALFRED?

[aishwaryap]

Hi @dv-fenix, apologies for the late response but in that situation I would still propagate the gradients (and hence keep detach_lang_emb = False). Pretraining language on ALFRED is not quite as effective as BERT-like pretraining would be so you would still want the language encoder to be finetuned.

[dv-fenix]

Oh cool! Thanks a lot @aishwaryap, I am closing this issue now.