Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website pictures are not included on the protected websites #68

Open
alarmatwork opened this issue Aug 2, 2023 · 2 comments
Open

Website pictures are not included on the protected websites #68

alarmatwork opened this issue Aug 2, 2023 · 2 comments
Assignees
Labels

Comments

@alarmatwork
Copy link

alarmatwork commented Aug 2, 2023

It seems like pictures are processed as a part of webpage for wikipedia, but they are not included when you try to grab password protected New Scientist article to read on the Kindle.
I can see that images are pointed to
src="../images/img-2834563815.jpeg"

but for some reason the images are not downloaded, even I probably have auth session present on the page, when the extensions is running.

Is there anything else I can do helping to fix or debug this issue?

Thanks for making such a useful extension!

@alexadam alexadam self-assigned this Aug 2, 2023
@alexadam alexadam added the bug label Aug 2, 2023
@alexadam
Copy link
Owner

alexadam commented Aug 2, 2023

You can try to download the extension from github and load it in Firefox or Chrome in dev. mode. Maybe there are some errors in the debugging console (I doubt it since that console is almost useless)

It might be because the request to download the image doesn't have the auth token / session, when it comes from the extension.

I'm planning a new release with bug fixes and better ways to extract info. I'll let you know if I find something.

@alarmatwork
Copy link
Author

Probably that's the reason.. I guess images are also protected with auth/session token. It would be probably good idea to make these requests too with the token present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants