Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-recursive version of file-seq #41

Merged

Conversation

skrat
Copy link
Contributor

@skrat skrat commented Nov 2, 2016

Fixes clojure-emacs/cider#1870

Do you need test for this? I wasn't quite sure how to write them. You can create a directory structure like:

foo/
  xxx/
    bar -> ../../bar (symlink)
bar/
  yyy/
    foo -> ../../foo (symlink)

Running (file-seq (File. "foo")) as compliment.utils/list-files does, will return an infinite sequence. Trying to consume it will likely lead to OOM.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.188% when pulling c11fd5a on skrat:robust-list-files into 8d838df on alexander-yakushev:master.

@alexander-yakushev
Copy link
Owner

Yeah, setting up the test going to be messy. Let's merge it as is:) Thank you!

@alexander-yakushev alexander-yakushev merged commit c11fd5a into alexander-yakushev:master Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants