Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Without $LANG var being set weather was not shown #13

Closed
farhansalam opened this issue Jun 30, 2017 · 4 comments
Closed

Without $LANG var being set weather was not shown #13

farhansalam opened this issue Jun 30, 2017 · 4 comments
Labels
Bug

Comments

@farhansalam
Copy link
Contributor

farhansalam commented Jun 30, 2017 •
edited

Issue Label:

  • [ ✔ ] enhancement

Description of bug or feature enhancement:

Without $LANG var being set weather was not populated

OS and OS version:

  • [✔ ] Mac

OS Version:
10.12.5 (16F73)
@farhansalam
Copy link
Contributor Author

Fixed here #14

@alexanderepstein
Copy link
Owner

alexanderepstein commented Jun 30, 2017 •
edited

This variable really came up as empty on your system? This variable should be a builtin so every system should have a value there, but I guess it cannot hurt to have a default value

@alexanderepstein
Copy link
Owner

Merged 4f44a45

@farhansalam
Copy link
Contributor Author

Yes, unfortunately it was empty I am using latest zsh version zsh 5.2 (x86_64-apple-darwin16.0.0). But anyways, thanks for the merge! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@farhansalam @alexanderepstein