Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock script returns "Not a valid stock symbol" #211

Closed
2 of 9 tasks
mathtd opened this issue Jan 8, 2020 · 7 comments
Closed
2 of 9 tasks

Stock script returns "Not a valid stock symbol" #211

mathtd opened this issue Jan 8, 2020 · 7 comments

Comments

@mathtd
Copy link

mathtd commented Jan 8, 2020

Issue Label:

  • Bug
  • New feature
  • Enhancement
  • New component

Description:
Looking for the price of AAPL returns "Not a valid stock symbol"

stocks AAPL
AAPL: Not a valid stock symbol

If its a bug make sure to include this section.

OS and OS version:

  • Mac
  • Linux 32 Bit
  • Linux 64 Bit
  • Windows 32 Bit
  • Windows 64 Bit

OS Version: macOS Catalina 10.15.2

@alexanderepstein
Copy link
Owner

alexanderepstein commented Jan 8, 2020

Are you running version 1.23.0? try running stocks -u

@mathtd
Copy link
Author

mathtd commented Jan 8, 2020

Yes 1.23.0.

stocks -u AAPL
Bash-Snippets is already the latest version

If I run bash -x stocks AAPL it seems that the problem comes from:

++ curl -A curl -s https://financialmodellingprep.com/api/v3/company/profile/AAPL
+ stockProfile='<html>
<head><title>301 Moved Permanently</title></head>
<body bgcolor="white">
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx/1.14.0 (Ubuntu)</center>
</body>
'/html>

@ghost
Copy link

ghost commented Jan 8, 2020 via email

@mathtd
Copy link
Author

mathtd commented Jan 8, 2020

That works!

@alexanderepstein
Copy link
Owner

So it seems the endpoint must have changed, will update the Stocks component with the new endpoint

@alexanderepstein
Copy link
Owner

Seems like they changed the URL from https://financialmodellingprep.com -> https://financialmodelingprep.com, I pushed a fix in bb561e5 and will release an update soon. Thanks for making me aware of the issue! If you want the changes now, you can rerun the git install steps and skip the step of checking out to the latest stable build.

@mathtd
Copy link
Author

mathtd commented Jan 9, 2020

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants