Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Consider using black (or similar) to format the codebase #33

Closed
samuelduchesne opened this issue Mar 4, 2024 · 5 comments

Comments

@samuelduchesne
Copy link

I generally recommend python developers to use a strict code formatter such as [black](https://black.readthedocs.io/en/stable/) to help the development process. The idea is simple: if the code is always formatted the same way, you are only committing actual code changes instead of formatting changes (black spaces, tabs, etc.)

@AlexanderJuestel
Copy link
Owner

@samuelduchesne processing.py was formatted using black in d133e51

Thanks for the suggestion!

@samuelduchesne
Copy link
Author

Great, you can also add black to your pyproject.toml if you want to specify a different configuration

@samuelduchesne
Copy link
Author

Also, you should format all the codebase with black not just the processing.py file - ie run black . from the root of the repo

@AlexanderJuestel
Copy link
Owner

Also, you should format all the codebase with black not just the processing.py file - ie run black . from the root of the repo

Codebase was formatted in 776ce06

@AlexanderJuestel
Copy link
Owner

Great, you can also add black to your pyproject.toml if you want to specify a different configuration

I added black to the pyproject.toml in f562220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants