Skip to content
This repository has been archived by the owner on Feb 10, 2020. It is now read-only.

Missing documentation about styling #9

Open
florentdestremau opened this issue May 31, 2017 · 6 comments
Open

Missing documentation about styling #9

florentdestremau opened this issue May 31, 2017 · 6 comments

Comments

@florentdestremau
Copy link

florentdestremau commented May 31, 2017

i had to include the css from https://github.com/alexandre-garrec/react-swipe-card/blob/master/stories/style.css to make it work

--
edit: from what I read in previous issues, you need an actual height set to master-root so it mainly had the side effect of giving it a size.
So it IS a lack of documentation, not exactly a bug

@florentdestremau
Copy link
Author

And i would add that your css classes are hard to integrate in an existing project because they are very wide:

  • .card
  • .alert
  • .animate
  • and not to mention the master-root 

You could use an ID before all of this to make sur this doesn't conflict with existing projects.
Suggestion:

  • prefix all above & similar with #react-swipe-card
  • somehow include the css in the packagist bundle ? had to copy & paste
  • make a default height for .master-root

@florentdestremau
Copy link
Author

But anyway cheers I'm not sure I'm going to use it as is for the reasons above but I like the idea 🙂

@generalpaulinski
Copy link

hey i have an issue even afterwards integrating the .css file...

TypeError: null is not an object (evaluating 'container.offsetWidth')

can somebody help me with that?

@DanaIliescu
Copy link

Having the same issue even with the css file included.
TypeError: Cannot read property 'offsetWidth' of null

@DanaIliescu
Copy link

It seems like the problem is React 16. After I downgraded to v 15.4.2 everything worked

@generalpaulinski
Copy link

@DanaIliescu i will try it with v 15.4.2. Thanks a lot for your answer!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants