Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseGlyph - Unexpectedly found nil while unwrapping an Optional value #81

Closed
4 tasks done
victor-sarda opened this issue May 28, 2018 · 7 comments
Closed
4 tasks done

Comments

@victor-sarda
Copy link

victor-sarda commented May 28, 2018

New Issue Checklist

Issue Description

Hi 馃憢,
I just installed BulletinBoard 2.0.0 and I get a crash when I'm running my build.
I get Thread 1: Fatal error: Unexpectedly found nil while unwrapping an Optional value in BulletinCloseButton.swift, line 50: let glyph = UIImage(named: "CloseGlyph", in: Bundle(for: BulletinCloseButton.self), compatibleWith: nil)!.

It looks like the CloseGlyph image is missing or something. I tried to set requiresCloseButton to false in my BLTNPageItem but it didn't change anything...

I looked into the BulletinBoard pod folder in my project and could find the CloseGlyph image.
I can share some code if you need too.

Thanks!

Environment

  • BulletinBoard Version: 2.0.0
  • iOS Version: 11.3
  • Device(s): iPhone 7, iPhone X simulator
@victor-sarda
Copy link
Author

I was able to reproduce the issue in a sample project with this simple code:

import UIKit
import BLTNBoard

class ViewController: UIViewController {

    lazy var onBoarding: BLTNItemManager = {

        let page = BLTNPageItem(title: "Testing")
        page.actionHandler = { (item: BLTNActionItem) in
            item.manager?.dismissBulletin(animated: true)
        }
        return BLTNItemManager(rootItem: page)
    }()

    override func viewDidLoad() {
        super.viewDidLoad()

    }

    override func viewDidAppear(_ animated: Bool) {
        super.viewDidAppear(animated)
        onBoarding.showBulletin(above: self)
    }
}

@yusuftor
Copy link

I got this issue too... please fix asap

@alexisakers
Copy link
Owner

alexisakers commented May 28, 2018

There was a problem with the Podspec, it didn't include the image resources. Sorry about this issue 馃槹

Could you please try if the fix works before I push the hotfix, by replacing the BulletinBoard line in your Podfile by this (to download from master):

pod 'BulletinBoard', :git => 'https://github.com/alexaubry/BulletinBoard.git', :branch => 'master'

And run pod update. Let me know if this fixes your issue.

@victor-sarda
Copy link
Author

Sure, no problem. I'll try it now

@victor-sarda
Copy link
Author

Yep it looks like it's fixing it 馃帀
Nice update btw 馃槄

@alexisakers
Copy link
Owner

You can update to 2.0.1 now. Sorry about the inconvenience.

@a2
Copy link
Collaborator

a2 commented May 28, 2018

High fiving a million angels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants