Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue most recent run #41

Open
AlexB52 opened this issue Dec 5, 2020 · 2 comments
Open

Queue most recent run #41

AlexB52 opened this issue Dec 5, 2020 · 2 comments
Labels
enchancements New feature or request

Comments

@AlexB52
Copy link
Owner

AlexB52 commented Dec 5, 2020

Sometimes specs get run over and over when the changes are made faster than the spec run.
We should

  • Queue a file when tests are already running.
  • Replace the file queued with the latest file to run when changes are made during a test run.
@AlexB52 AlexB52 added this to To Do in v1.0.0 via automation Dec 5, 2020
@AlexB52 AlexB52 removed this from To Do in v1.0.0 Mar 10, 2021
@AlexB52 AlexB52 added enchancements New feature or request and removed enhancement labels Mar 16, 2021
@AlexB52 AlexB52 changed the title Queue next spec run Queue most recent run Apr 12, 2021
@konovalov-nk
Copy link

konovalov-nk commented Jun 16, 2022

Do you have suggestion where in the codebase can we add this feature?
I might try looking into that on a weekend 👀

Been using this gem for a while recently and love it ❤️

@AlexB52
Copy link
Owner Author

AlexB52 commented Jun 19, 2022

Thanks for reaching out @konovalov-nk .

I'd say the main idea would be to make the runners feed from a newly introduced queue that gets populated or updated after a file change. A run would be triggered by a queue being populated or still full after a run has finished.

Notes:

  • I expect changes to be in Runner base class, Program class and introduce a new queue concept but that's my gut feeling.
  • We also used the observable module in the past, not saying we should use it but that could be a lead. See exe/retest file
  • If you create a PR please add some unit/integration tests (in the test folder) that shows everything works as expected.

Thanks @konovalov-nk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enchancements New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants