Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause monitoring #77

Merged
merged 3 commits into from
May 23, 2023
Merged

Pause monitoring #77

merged 3 commits into from
May 23, 2023

Conversation

jwallet
Copy link
Contributor

@jwallet jwallet commented May 18, 2023

  • to enable more options I removed the alert "show more"
  • added option to "pause" the network monitoring and "resume" it.

@alexbrazier
Copy link
Owner

I like the pause option, but is it not still possible to use the Alert for it? At some point I was thinking of cleaning it up to look more like this so there could be more options next to the search bar and maybe eventually switching to an ActionSheet or Modal.

image

This option seems to limit us to 3 options like the Alert on Android as any more would cause it to go onto more lines
image

@jwallet
Copy link
Contributor Author

jwallet commented May 20, 2023

You are totally right
Alert is limited to 3 options. My option is limited by the device width. The dot button is the way to go with a popover menu options.

@jwallet
Copy link
Contributor Author

jwallet commented May 21, 2023

options moved to a modal

Copy link
Owner

@alexbrazier alexbrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but seems there are some merge conflicts to resolve

@alexbrazier alexbrazier merged commit 11d4494 into alexbrazier:master May 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants